Skip to content

Fix invalid SQL generation with empty where groups #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matthi4s merged 1 commit into from
Feb 3, 2026
Merged

Fix invalid SQL generation with empty where groups #38

matthi4s merged 1 commit into from
Feb 3, 2026

Conversation

@JulianVennen
Copy link
Member

@JulianVennen JulianVennen commented Jan 7, 2026 •
edited
Loading

An empty where group currently generates the following SQL which causes a MYSQL syntax error:

SELECT * FROM `test` WHERE ()

This PR fixes that by not returning empty where groups from the Query class.

@matthi4s matthi4s merged commit 03031e5 into aternosorg:master Feb 3, 2026
3 checks passed
@JulianVennen JulianVennen deleted the fix-empty-where branch February 3, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthi4s matthi4s matthi4s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JulianVennen @matthi4s